Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in ingress error message #505

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

lihongan
Copy link
Contributor

Currently the actual output looks like

│ Cannont upate default ingress forcluster '28gjcif4b7fluce0uksce104492bjk0h': status is 400 ...

Expected:

Cannot update default ingress for cluster ...

Copy link

openshift-ci bot commented Jan 15, 2024

Hi @lihongan. Thanks for your PR.

I'm waiting for a terraform-redhat member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lihongan
Copy link
Contributor Author

cc @gdbranco

Copy link

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gdbranco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gdbranco
Copy link
Contributor

/ok-to-test

@nirarg
Copy link
Member

nirarg commented Jan 15, 2024

/lgtm

@nirarg
Copy link
Member

nirarg commented Jan 15, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 968b275 into terraform-redhat:main Jan 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants