Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-5422 | ci: Add commit format validation #503

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

nirarg
Copy link
Member

@nirarg nirarg commented Jan 14, 2024

This change is added to validate the commit format for better contribution Includes:

  • Pre-merge commit message format validator script
  • PR template
  • Add more details to CONTRIBUTION page

Fixes: OCM-5422

@openshift-ci openshift-ci bot requested review from ciaranRoche and vkareh January 14, 2024 09:26
@nirarg nirarg force-pushed the commit-message branch 2 times, most recently from 36c8465 to e80b552 Compare January 14, 2024 11:14
This change is added to validate the commit format for better contribution
Includes:
* Pre-merge commit message format validator script
* PR template
* Add more details to CONTRIBUTION page
@nirarg
Copy link
Member Author

nirarg commented Jan 14, 2024

/cc @bardielle

@openshift-ci openshift-ci bot requested a review from bardielle January 14, 2024 14:38
@nirarg
Copy link
Member Author

nirarg commented Jan 14, 2024

/uncc @vkareh

@openshift-ci openshift-ci bot removed the request for review from vkareh January 14, 2024 14:39
Copy link
Contributor

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0bfc317 into terraform-redhat:main Jan 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants