Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes with the recovering status from the backend #496

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

yuwang-RH
Copy link
Contributor

  • use the data from the backend endpoints to store the original machinepool parameters for recovering
  • Update to use pointer on the attributes of DefaultMachinePoolArgs
  • related updates on default machinepool test cases

Rerun logs is here https://privatebin.corp.redhat.com/?631d4d4efe8bb320#D5rrqh2vMoyY1duBKnmFsTAbMCthmyd8q2Rx33YkHzyj

Copy link

openshift-ci bot commented Jan 9, 2024

Hi @yuwang-RH. Thanks for your PR.

I'm waiting for a terraform-redhat member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuwang-RH
Copy link
Contributor Author

@xueli181114 @shellymiron @amalykhi Could you help review this PR?

@xueli181114
Copy link
Contributor

/ok-to-test

@xueli181114
Copy link
Contributor

/lgtm

@yuwang-RH
Copy link
Contributor Author

/test rosa-sts-private-critical-high-presubmit

@yuwang-RH
Copy link
Contributor Author

/test rosa-sts-advanced-critical-high-presubmit

@yuwang-RH
Copy link
Contributor Author

/test rosa-sts-private-critical-high-presubmit

@yuwang-RH
Copy link
Contributor Author

/test rosa-sts-advanced-critical-high-presubmit

@amalykhi
Copy link
Contributor

/retest

@yuwang-RH
Copy link
Contributor Author

/retest-required

3 similar comments
@yuwang-RH
Copy link
Contributor Author

/retest-required

@yuwang-RH
Copy link
Contributor Author

/retest-required

@yuwang-RH
Copy link
Contributor Author

/retest-required

@xueli181114
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 15, 2024
@xueli181114
Copy link
Contributor

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm label Jan 15, 2024
@yuwang-RH
Copy link
Contributor Author

/test rosa-sts-advanced-critical-high-presubmit

@yuwang-RH
Copy link
Contributor Author

/test rosa-sts-private-critical-high-presubmit

@xueli181114
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 15, 2024
@xueli181114
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xueli181114

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 29f853e into terraform-redhat:main Jan 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants