OCM-5428 | OCM-5414 | OCM-5409: machine pool data source

[bardielle]

This PRs:

• OCM-5414: add availability_zonese as a computed attribute to machinepool resource
• OCM-5409: add aws_submet_ids as a computed attribute to machinepool resource
• OCM-5428: add machine-pool datasource
• Generate docs

[openshift-ci-robot]

@bardielle: This pull request references OCM-5409 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

This PRs:

• OCM-5414: add availability_zonese as a computed attribute to machinepool resource
• OCM-5409: add aws_submet_ids as a computed attribute to machinepool resource
• OCM-5428: add machine-pool datasource
• Generate docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bardielle]

for the configuration file:

data "rhcs_machine_pool" "mp2" {
  cluster = "28k1v2l8pofsbmor1injvng0d8i7ie3q"
  id = "worker"
}


resource "rhcs_machine_pool" "machine_pool" {
  cluster                 = "28k1v2l8pofsbmor1injvng0d8i7ie3q"
  name                    = "test"
  machine_type =  "m5.xlarge"
  replicas = 3

}

output:

#the output of mp resource:
terraform state show rhcs_machine_pool.machine_pool
# rhcs_machine_pool.machine_pool:
resource "rhcs_machine_pool" "machine_pool" {
    availability_zones      = [
        "us-east-2a",
        "us-east-2b",
        "us-east-2c",
    ]
    aws_subnet_ids          = [
        "subnet-0afdd90afd6008ff0",
        "subnet-04c6fcc2ce591fb4b",
        "subnet-0a437951b8b316357",
    ]
    cluster                 = "28k1v2l8pofsbmor1injvng0d8i7ie3q"
    disk_size               = 300
    id                      = "test"
    machine_type            = "m5.xlarge"
    multi_availability_zone = true
    name                    = "test"
    replicas                = 3
}




terraform state show data.rhcs_machine_pool.mp2
# data.rhcs_machine_pool.mp2:
data "rhcs_machine_pool" "mp2" {
    availability_zones      = [
        "us-east-2a",
        "us-east-2b",
        "us-east-2c",
    ]
    aws_subnet_ids          = [
        "subnet-0afdd90afd6008ff0",
        "subnet-04c6fcc2ce591fb4b",
        "subnet-0a437951b8b316357",
    ]
    cluster                 = "28k1v2l8pofsbmor1injvng0d8i7ie3q"
    disk_size               = 300
    id                      = "terr-cluster-machine-pool"
    machine_type            = "m5.xlarge"
    multi_availability_zone = true
    name                    = "terr-cluster-machine-pool"
    replicas                = 6
}

[nirarg]

Most of the comments here are suggestion for different descriptions as the descriptions in the data source need to be different from the descriptions in the resource (particular avoid using common.ValueCannotBeChangedStringDescription message)

[nirarg]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirarg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nirarg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment