Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add htpasswd test and expanding current IDP infrastructure- automating ocp63151 #328

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Conversation

shellymiron
Copy link
Contributor

Test case automated: OCP-63151

passing result:
image

@openshift-ci openshift-ci bot requested review from AsherShoshan and nirarg October 4, 2023 07:59
@shellymiron
Copy link
Contributor Author

@amalykhi @tshefi @nirarg @bardielle @xueli181114 please review :)

@shellymiron shellymiron changed the title add httpasswd test and expanding current IDP infrastructure- automating ocp63151 add htpasswd test and expanding current IDP infrastructure- automating ocp63151 Oct 4, 2023
Copy link
Contributor

@sagidayan sagidayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few comments. But looks good 👏🏽

tests/e2e/idps_test.go Outdated Show resolved Hide resolved
tests/e2e/idps_test.go Outdated Show resolved Hide resolved
tests/e2e/idps_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@sagidayan sagidayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Great job!

tests/utils/exec/idps.go Outdated Show resolved Hide resolved
tests/utils/exec/idps.go Outdated Show resolved Hide resolved
tests/utils/exec/idps.go Outdated Show resolved Hide resolved
Copy link
Member

@nirarg nirarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment/question
Other than that it looks good

tests/e2e/idps_test.go Outdated Show resolved Hide resolved
@amalykhi
Copy link
Contributor

amalykhi commented Oct 5, 2023

/lgtm

@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Oct 5, 2023
@shellymiron
Copy link
Contributor Author

@sagidayan @amalykhi @nirarg can you /lgtm & /approve if ok?

@sagidayan
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved label Oct 8, 2023
tests/e2e/idps_test.go Outdated Show resolved Hide resolved
@bardielle
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Oct 8, 2023
@sagidayan
Copy link
Contributor

/lgtm

@bardielle
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bardielle, sagidayan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit c7fd671 into terraform-redhat:main Oct 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants