Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-3909: Fix availability zones to ListNull in case nothing returned #315

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

nirarg
Copy link
Member

@nirarg nirarg commented Sep 26, 2023

In case the user doesn't provide the availability zone, cluster create returnes before it ready and with empty azs list.
This change is done in order to avoid from the following error:
Screenshot from 2023-09-26 11-01-31

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2023

@nirarg: This pull request references OCM-3909 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

In case the user doesn't provide the availability zone, cluster create returnes before it ready and with empty azs list.
This change is done in order to avoid from the following error:
Screenshot from 2023-09-26 11-01-31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nirarg
Copy link
Member Author

nirarg commented Sep 26, 2023

/cc @JohnStrunk

@openshift-ci openshift-ci bot requested a review from JohnStrunk September 26, 2023 18:56
Copy link
Member

@JohnStrunk JohnStrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nirarg
Copy link
Member Author

nirarg commented Sep 27, 2023

/retest

@sagidayan
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, sagidayan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b14f879 into terraform-redhat:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants