Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update proxy in cluster rosa #307

Closed
wants to merge 2 commits into from

Conversation

bardielle
Copy link
Member

@bardielle bardielle commented Sep 21, 2023

While updating proxy to nil it wasn't update the internal attributes in ocm backend

@bardielle bardielle requested review from tsorya and nirarg September 21, 2023 09:27
@bardielle bardielle force-pushed the fix_proxy branch 2 times, most recently from 6840220 to 4de49bc Compare September 21, 2023 11:16
@nirarg
Copy link
Member

nirarg commented Sep 21, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirarg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

@bardielle: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/managed-oidc-config-e2e-presubmit 731365a link true /test managed-oidc-config-e2e-presubmit
ci/prow/unmanaged-oidc-config-e2e-presubmit 731365a link true /test unmanaged-oidc-config-e2e-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bardielle bardielle closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants