Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General TF Updates #217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

General TF Updates #217

wants to merge 1 commit into from

Conversation

EricPonvelle
Copy link
Contributor

@EricPonvelle EricPonvelle commented Jul 31, 2023 •
edited
Loading

This PR is to capture a bunch of changes for the Terraform documentation.

  • OSDOCS-6870 - Created a Machine Pools guide page that collects the endpoints.
  • OSDOCS-7474 - Created a Cluster Admin guide

@openshift-ci openshift-ci bot requested review from bardielle and gdbranco July 31, 2023 18:11
@EricPonvelle EricPonvelle force-pushed the GeneralTF-Updates branch 2 times, most recently from 557f49c to 067baae Compare August 16, 2023 14:34
@bardielle
Copy link
Member

@JohnStrunk please also review it

JohnStrunk
JohnStrunk reviewed Aug 23, 2023
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
JohnStrunk
JohnStrunk reviewed Aug 23, 2023
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/guides/machine_pool-2.md Outdated Show resolved Hide resolved
docs/guides/machine_pool-2.md Outdated Show resolved Hide resolved
docs/guides/machine_pool-2.md Outdated Show resolved Hide resolved
docs/guides/machine_pool-2.md Outdated Show resolved Hide resolved
@EricPonvelle EricPonvelle force-pushed the GeneralTF-Updates branch 15 times, most recently from eccbd8b to 37be4c6 Compare September 6, 2023 16:25
@EricPonvelle EricPonvelle force-pushed the GeneralTF-Updates branch 2 times, most recently from 4843ebf to 0139954 Compare September 6, 2023 16:29
EricPonvelle
EricPonvelle commented Sep 6, 2023
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
docs/guides/cluseter-admin.md Outdated
@@ -0,0 +1,31 @@
---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirarg can you review this to determine if this guide satisfies https://issues.redhat.com/browse/OSDOCS-7474

I'll add a guide in the ROSA docs after this and the landing page merge.

@EricPonvelle EricPonvelle force-pushed the GeneralTF-Updates branch 2 times, most recently from f8cfc11 to ed54dc5 Compare September 8, 2023 16:51
arendej
arendej requested changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@arendej arendej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes requested

docs/guides/machine-pool.md Outdated Show resolved Hide resolved
docs/guides/machine-pool.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ericponvelle. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nirarg
nirarg reviewed Sep 28, 2023
View reviewed changes
docs/guides/cluster-admin.md Show resolved Hide resolved
docs/guides/cluster-admin.md
Instructions on how to create a Rosa Openshift cluster admin when you create your cluster with the terraform provider.
---

# Creating a cluster admin user for your ROSA cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this has enough capacity to set this as a stand alone guide
Can't it just be short sentence under the admin_credentials attribute in the rhcs_cluster_rosa_classic resource?
https://registry.terraform.io/providers/terraform-redhat/rhcs/latest/docs/resources/cluster_rosa_classic#admin_credentials

@arendej what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but let's leave it as a small guide for now until we can get this spreadsheet built out. Then, I can include in-line explanations like this.

docs/guides/machine-pool.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amalykhi
Copy link
Contributor

amalykhi commented Dec 5, 2023

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 7, 2024

@EricPonvelle: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rosa-sts-private-critical-high-presubmit ef38dec link true /test rosa-sts-private-critical-high-presubmit
ci/prow/rosa-sts-advanced-critical-high-presubmit ef38dec link true /test rosa-sts-advanced-critical-high-presubmit
ci/prow/e2e-presubmits-images ef38dec link true /test e2e-presubmits-images
ci/prow/e2e-presubmits-rosa-sts-advanced-critical-high-presubmit ef38dec link true /test e2e-presubmits-rosa-sts-advanced-critical-high-presubmit
ci/prow/e2e-presubmits-rosa-sts-private-critical-high-presubmit ef38dec link true /test e2e-presubmits-rosa-sts-private-critical-high-presubmit
ci/prow/e2e-presubmits-rosa-hcp-advanced-critical-high-presubmit ef38dec link true /test e2e-presubmits-rosa-hcp-advanced-critical-high-presubmit
ci/prow/e2e-presubmits-rosa-hcp-private-critical-high-presubmit ef38dec link true /test e2e-presubmits-rosa-hcp-private-critical-high-presubmit
ci/prow/e2e-images ef38dec link true /test e2e-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirarg nirarg nirarg left review comments

@bardielle bardielle bardielle left review comments

@JohnStrunk JohnStrunk JohnStrunk left review comments

@arendej arendej arendej requested changes

@gdbranco gdbranco Awaiting requested review from gdbranco

Assignees
No one assigned
Labels
do-not-merge/hold needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@EricPonvelle @bardielle @openshift-merge-robot @amalykhi @JohnStrunk @arendej @nirarg