Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about Vault 1.2 for token_* fields #565

Merged
merged 5 commits into from
Oct 30, 2019

Conversation

lawliet89
Copy link
Contributor

#487
deprecated some fields that were deprecated in Vault 1.2

Add more context to deprecation messages that the new token_* fields
are only for Vault >= 1.2

hashicorp#487
deprecated some fields that were deprecated in Vault 1.2

Add more context to deprecation messages that the new `token_*` fields
are only for Vault >= 1.2
@Techcadia
Copy link

Would love to see this merged. Would have save us some time when upgrading.

@kalafut kalafut self-assigned this Oct 23, 2019
* `token_period` - (Optional) If set, indicates that the
token generated using this role should never expire. The token should be renewed within the
duration specified by this value. At each renewal, the token's TTL will be set to the
value of this field. The maximum allowed lifetime of token issued using this
Copy link
Contributor

@kalafut kalafut Oct 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the The maximum allowed lifetime of token issued using this role text is an error (here and in the same block elsewhere.) Looks like that might be an error that predates this PR actually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalafut I've fixed the text.

Copy link
Contributor

@kalafut kalafut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the token_period comment.

Copy link
Contributor

@kalafut kalafut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks!

@kalafut kalafut merged commit ada9249 into hashicorp:master Oct 30, 2019
@lawliet89 lawliet89 deleted the 1.2-deprecation-message branch October 31, 2019 01:22
martinssipenko added a commit to martinssipenko/terraform-provider-vault that referenced this pull request Oct 31, 2019
* master:
  fix code blocks formatting and vault_azure_secret_* links titles (hashicorp#588)
  Update CHANGELOG.md
  Add information about Vault 1.2 for `token_*` fields (hashicorp#565)
  Fix grammar
  Add missing docs for `identity_group_policies`
  Fix missing quote that breaks documentation rendering.
  repushing
  Adding sidebar link to crl_config
  Add whitelines to address hanging "```"
  Added pull request template
martinssipenko added a commit to martinssipenko/terraform-provider-vault that referenced this pull request Oct 31, 2019
* master:
  fix code blocks formatting and vault_azure_secret_* links titles (hashicorp#588)
  Update CHANGELOG.md
  Add information about Vault 1.2 for `token_*` fields (hashicorp#565)
  Fix grammar
  Add missing docs for `identity_group_policies`
  Fix missing quote that breaks documentation rendering.
  repushing
  Adding sidebar link to crl_config
  Add whitelines to address hanging "```"
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
* master:
  fix code blocks formatting and vault_azure_secret_* links titles (hashicorp#588)
  Update CHANGELOG.md
  Add information about Vault 1.2 for `token_*` fields (hashicorp#565)
  Fix grammar
  Add missing docs for `identity_group_policies`
  Fix missing quote that breaks documentation rendering.
  repushing
  Adding sidebar link to crl_config
  Add whitelines to address hanging "```"
  Added pull request template
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
* master:
  fix code blocks formatting and vault_azure_secret_* links titles (hashicorp#588)
  Update CHANGELOG.md
  Add information about Vault 1.2 for `token_*` fields (hashicorp#565)
  Fix grammar
  Add missing docs for `identity_group_policies`
  Fix missing quote that breaks documentation rendering.
  repushing
  Adding sidebar link to crl_config
  Add whitelines to address hanging "```"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants