Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code blocks formatting and vault_azure_secret_* links titles #588

Merged
merged 3 commits into from
Oct 30, 2019
Merged

fix code blocks formatting and vault_azure_secret_* links titles #588

merged 3 commits into from
Oct 30, 2019

Conversation

Andor
Copy link
Contributor

@Andor Andor commented Oct 29, 2019

Fix current wrong formatting for code blocks:
Screenshot_20191029_133706

Also, fix azure-related links text:
Screenshot_20191029_134124

@Andor Andor changed the title documentation: fix code blocks formatting fix code blocks formatting Oct 29, 2019
@Andor Andor changed the title fix code blocks formatting fix code blocks formatting and vault_azure_secret_* links titles Oct 29, 2019
@kalafut kalafut self-assigned this Oct 30, 2019
Copy link
Contributor

@kalafut kalafut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! These changes look fine, but can you please remedy the merge conflicts that Github is reporting?

Copy link
Contributor

@kalafut kalafut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conflicts were really minor so I just fixed them.

@kalafut kalafut merged commit 56073ab into hashicorp:master Oct 30, 2019
@kalafut
Copy link
Contributor

kalafut commented Oct 30, 2019

Thanks!

martinssipenko added a commit to martinssipenko/terraform-provider-vault that referenced this pull request Oct 31, 2019
* master:
  fix code blocks formatting and vault_azure_secret_* links titles (hashicorp#588)
  Update CHANGELOG.md
  Add information about Vault 1.2 for `token_*` fields (hashicorp#565)
  Fix grammar
  Add missing docs for `identity_group_policies`
  Fix missing quote that breaks documentation rendering.
  repushing
  Adding sidebar link to crl_config
  Add whitelines to address hanging "```"
  Added pull request template
martinssipenko added a commit to martinssipenko/terraform-provider-vault that referenced this pull request Oct 31, 2019
* master:
  fix code blocks formatting and vault_azure_secret_* links titles (hashicorp#588)
  Update CHANGELOG.md
  Add information about Vault 1.2 for `token_*` fields (hashicorp#565)
  Fix grammar
  Add missing docs for `identity_group_policies`
  Fix missing quote that breaks documentation rendering.
  repushing
  Adding sidebar link to crl_config
  Add whitelines to address hanging "```"
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
* master:
  fix code blocks formatting and vault_azure_secret_* links titles (hashicorp#588)
  Update CHANGELOG.md
  Add information about Vault 1.2 for `token_*` fields (hashicorp#565)
  Fix grammar
  Add missing docs for `identity_group_policies`
  Fix missing quote that breaks documentation rendering.
  repushing
  Adding sidebar link to crl_config
  Add whitelines to address hanging "```"
  Added pull request template
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
* master:
  fix code blocks formatting and vault_azure_secret_* links titles (hashicorp#588)
  Update CHANGELOG.md
  Add information about Vault 1.2 for `token_*` fields (hashicorp#565)
  Fix grammar
  Add missing docs for `identity_group_policies`
  Fix missing quote that breaks documentation rendering.
  repushing
  Adding sidebar link to crl_config
  Add whitelines to address hanging "```"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants