Add cloud identity group #6681
Merged
Add cloud identity group #6681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add cloud identity to mm * make labels key value pair * add cloud identity group * fix white spacing, add description to update test * make tests beta-only * make customer id var beta-only * Update products/cloudidentity/api.yaml Co-authored-by: Dana Hoffman <[email protected]> * Update products/cloudidentity/terraform.yaml Co-authored-by: Dana Hoffman <[email protected]> * update code review comments * move unless ga to top of file for test * move unless ga back * add group membership back in * remove last comma * update per review comments * add group membership test for user * update admin -> identity, tabs -> spaces Co-authored-by: Dana Hoffman <[email protected]> Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
modular-magician
deleted the
downstream-pr-f78a0a938c888f3a8d988b473286d8418e4c3a96
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3479
I've commented out a few un-implemented things (per email thread), but will update/include them as I hear back from the rest of the team.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3696