Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change credentials to sensitive #6272

Conversation

modular-magician
Copy link
Collaborator

fixes #5599

Release Note Template for Downstream PRs (will be copied)

storage: Marked the credentials field in `google_storage_object_signed_url` as sensitive so it doesn't expose private credentials.

Derived from GoogleCloudPlatform/magic-modules#3462

@ghost ghost added the size/xs label May 1, 2020
@modular-magician modular-magician merged commit 89d81ac into hashicorp:master May 1, 2020
@ghost
Copy link

ghost commented Jun 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 1, 2020
@modular-magician modular-magician deleted the downstream-pr-78a241a5535247ce27c3e145c0a8084a40eb67e1 branch November 17, 2024 00:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_storage_object_signed_url -> credentials must have sensitive flag set to true
1 participant