Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change credentials to sensitive #3462

Merged
merged 1 commit into from
May 1, 2020

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented May 1, 2020

fixes hashicorp/terraform-provider-google#5599

Release Note Template for Downstream PRs (will be copied)

storage: Marked the credentials field in `google_storage_object_signed_url` as sensitive so it doesn't expose private credentials.

@chrisst chrisst requested a review from c2thorn May 1, 2020 22:52
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 3 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 3 insertions(+), 2 deletions(-))

@chrisst chrisst merged commit 78a241a into GoogleCloudPlatform:master May 1, 2020
@chrisst chrisst deleted the signed-url-sensitive branch May 1, 2020 23:20
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_storage_object_signed_url -> credentials must have sensitive flag set to true
4 participants