Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop converting timeouts to/from minutes #6218

Conversation

modular-magician
Copy link
Collaborator

Noticed this again while working on #3954, and figured this is as good a time as any to actually fix it.

Release Note Template for Downstream PRs (will be copied)

* all: fixed bug where timeouts specified in units other than minutes were getting incorrectly rounded. Also fixed several instances of timeout values being used from the wrong method.

Derived from GoogleCloudPlatform/magic-modules#3421

@ghost ghost added the size/xl label Apr 27, 2020
@modular-magician modular-magician merged commit 85e2390 into hashicorp:master Apr 27, 2020
@ghost
Copy link

ghost commented May 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 28, 2020
@modular-magician modular-magician deleted the downstream-pr-3eee3a1e85302bb693c4afb8e9ce9d5ffbe339d6 branch November 16, 2024 23:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant