Add support for GCP PubSub Subscription filter

[brachipa]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

In GCP PubSub there is new feature filters

it will be very helpful if you support it, since it is useful feature in PubSub.
I cab't create the PubSub in TF and then add the filter since the filter can't be set after subscription is created.

New or Affected Resource(s)

• google_PubSub

Potential Terraform Configuration

resource "google_pubsub_topic" "example" {
  name = "example-topic"
}

resource "google_pubsub_subscription" "example" {
  name  = "example-subscription"
  topic = google_pubsub_topic.example.name

  labels = {
    foo = "bar"
  }

  # 20 minutes
  message_retention_duration = "1200s"
  retain_acked_messages      = true

  ack_deadline_seconds = 20

  expiration_policy {
    ttl = "300000.5s"
  }

 filter="attributes:domain"
--


"

}

References

[tim-codes]

Looking to contribute to this issue however getting a bit confused by the source code. I can see that the resource is generated by magic modules as it has the "AUTO GENERATED CODE" warning in the source file. However, following the contribution guide and the link to this repository I'm unable to find the corresponding code for the pubsub subscription.

[danawillow]

@tim-codes the third_party folder only has the non-generated resources. Since pubsub is generated, its definition lives at https://github.com/GoogleCloudPlatform/magic-modules/tree/master/products/pubsub (api.yaml and terraform.yaml). I'd also recommend reading through the README/codelab to get a sense of how to do things in MM, but happy to have you help out with this! Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!