RESOURCE-586 Fix the build lint issue in inspec-gcp #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Soumyodeep Karmakar <[email protected]>
soumyo13
changed the title
sa-progress
approved these changes
Jan 30, 2023
soumyo13
deleted the
RESOURCE-586-fix-the-build-lint-issue-in-inspec-gcp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Soumyodeep Karmakar [email protected]
Description
We got this bellow offense in the buildkite. We are fixing the mentioned offense.
Issues Resolved
Offenses:
libraries/google_sql_database_instance.rb:104:33: C: [Correctable] Style/ZeroLengthPredicate: Use empty? instead of size.zero?.
return '' if !@ip_addresses.size.zero? || @ip_addresses[0].ip_address.nil?
^^^^^^^^^^
971 files inspected, 1 offense detected, 1 offense autocorrectable
RuboCop failed!
🚨 Error: The command exited with status 1
user command error: The plugin docker command hook exited with status 1
Please ensure commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco