Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_bigtable_app_profile resource should support long form 'id' for big_table instance reference #5751

Assignees
Labels

Comments

@venkykuberan
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Affected Resource(s)

  • google_bigtable_instance
  • google_bigtable_app_profile

Terraform Configuration Files

google_bigtable_app_profile resource takes only short form of instance name, it should accept both the formats. Using long format throws 404 error.

  • {{instance-name}}
  • projects/{{project}}/instances/{{instance-name}}

Potential Terraform Config

resource "google_bigtable_instance" "bgtable-instance" {
#   provider      = google-beta
  name          = "tf-instance"
  instance_type = "PRODUCTION"
  cluster {
    cluster_id   = "tf-instance-cluster"
    zone         = "us-central1-b"
    storage_type = "HDD"
    num_nodes = 3
  }
}

resource "google_bigtable_app_profile" "ap" {
  instance       = google_bigtable_instance.bgtable-instance.id
  app_profile_id = "bt-profile"
  multi_cluster_routing_use_any = true
  ignore_warnings               = true
  depends_on = [google_bigtable_instance.bgtable-instance]
} 

Debug Output

Panic Output

Expected Behavior

Actual Behavior

404. That’s an error.

The requested URL /v2/projects/xxxx/instances/projects/xxxx/instances/tf-instance/appProfiles?alt=json&appProfileId=bt-profile was not found on this server. That’s all we know.

Steps to Reproduce

  1. terraform apply

Important Factoids

References

  • #0000
@ghost ghost added the bug label Feb 25, 2020
@emilymye
Copy link
Contributor

A workaround would be to use google_bigtable_instance.bgtable-instance.name instead of .id - is there a specific reason you want to use the ID? Right now this is only a field we use to construct the URL, hence the 404

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.