Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_bigtable_table and google_bigtable_gc_policy resources should support long form 'id' for big_table instance reference #5820

Closed
Assignees
Labels

Comments

@venkykuberan
Copy link
Contributor

venkykuberan commented Mar 3, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Affected Resource(s)

  • google_bigtable_instance
  • google_bigtable_table
  • google_bigtable_gc_policy

Terraform Configuration Files

resource google_bigtable_instance "bigtable-ah" {
  name          = "bigtable-ah"
  project       = var.project_id
  instance_type = "PRODUCTION" // PRODUCTION DEVELOPMENT

  cluster {
    cluster_id   = "bigtable-main-cluster-2"
    num_nodes    = 3
    storage_type = "HDD"
    zone         = var.zone //"europe-west4-b"
  }
}
resource "google_bigtable_table" "table" {
  name          = "tf-table"
  instance_name = google_bigtable_instance.bigtable-ah.id

  column_family {
    family = "name"
  }
}

resource "google_bigtable_gc_policy" "policy" {
  instance_name = google_bigtable_instance.bigtable-ah.name
  table         = google_bigtable_table.table.name
  column_family = "name"

  mode = "UNION"

  max_age {
    days = 7
  }

  max_version {
    number = 10
  }
}

Debug Output

Panic Output

Expected Behavior

Terraform/Provider should accept both name and id attributes alike other resources

Actual Behavior

Error creating table. rpc error: code = InvalidArgument desc = When parsing 'projects/xxx/instances/projects/xxxinstances/bigtable-ah' : Instance name expected in the form 'projects/<project_id>/instances/<instance_id>'

Steps to Reproduce

  1. terraform apply

Important Factoids

References

@ghost ghost added the bug label Mar 3, 2020
@venkykuberan venkykuberan changed the title google_bigtable_table resource should support long form 'id' for big_table instance reference google_bigtable_table and google_bigtable_gc_policy resources should support long form 'id' for big_table instance reference Mar 3, 2020
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.