Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate google_target_http_proxy using MagicModule #1391

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Generate google_target_http_proxy using MagicModule #1391

merged 1 commit into from
Apr 27, 2018

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Apr 26, 2018 •
edited by rosbo
Loading

Bonus:

  • Configurable timeouts
  • More flexible terraform import use
  • creation_timestamp output field

cc/ @rosbo

@modular-magician modular-magician mentioned this pull request Apr 26, 2018
Merged
@rosbo rosbo requested a review from nat-henderson April 26, 2018 22:55
nat-henderson
nat-henderson approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge at will, as long as the tests pass.

@rosbo
Copy link
Contributor

rosbo commented Apr 26, 2018 

--- PASS: TestAccComputeTargetHttpProxy_basic (90.70s)
--- PASS: TestAccComputeTargetHttpProxy_update (103.39s)

@rosbo rosbo merged commit b3a722e into hashicorp:master Apr 27, 2018
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
@modular-magician @rosbo
Generate google_target_http_proxy using MagicModule (hashicorp#1391)
2784022
@ghost
Copy link

ghost commented Nov 18, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 18, 2018
@modular-magician modular-magician deleted the codegen-pr-119 branch November 16, 2024 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nat-henderson nat-henderson nat-henderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@modular-magician @rosbo @nat-henderson