Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release TargetHttpProxy resource in Terraform #119

Merged
merged 2 commits into from
Apr 27, 2018
Merged

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Apr 26, 2018


[all]

[terraform]

Generate google_target_http_proxy using MagicModule

[puppet]

[puppet-dns]

[puppet-compute]

[chef]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#1391
depends: GoogleCloudPlatform/puppet-google-sql#13
depends: GoogleCloudPlatform/puppet-google-compute#17

@rosbo rosbo requested review from nelsonjr and nat-henderson April 26, 2018 22:55
@rosbo
Copy link
Contributor Author

rosbo commented Apr 26, 2018

I won't submit the change in puppet-google-sql which only deletes the test coverage file.

@nat-henderson
Copy link
Contributor

Yeah, we'll have to handle that one of these days, but until then it's a legitimate diff that I think the Magician is right to point out.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 9953bff) have been included in your existing downstream PRs.

@modular-magician modular-magician merged commit 2592cfd into master Apr 27, 2018
@rosbo rosbo deleted the tf-http-proxy branch April 27, 2018 01:08
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit ac89e63) have been included in your existing downstream PRs.

chrisst pushed a commit to chrisst/magic-modules that referenced this pull request Oct 26, 2018
…isting-import-docs

Update existing resources import docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants