Configure release channel when creating GKE clusters #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
4 tasks
slevenick
reviewed
Oct 14, 2019
| "channel": c.Channel, | ||
| }) | ||
| } else { | ||
| // Explicitly set the network policy to the default. |
There was a problem hiding this comment.
Not a "network policy", so this comment can be updated.
Why do we want to explicitly set the channel to UNSPECIFIED if it is not returned by the API? Typically there is a difference between receiving a value like UNSPECIFIED and not receiving anything at all, but we would lose that in this case
There was a problem hiding this comment.
In this case, when release channel is set to UNSPECIFIED, the GKE API returns a nil containerBeta.ReleaseChannel. As such, I had to make the assumption that the returned nil object refers to the UNSPECIFIED channel.
I would add an additional test to test for invalid channels.
modular-magician
force-pushed
the
codegen-pr-2414
branch
from
0077792 to
d05c0eb
Compare
Signed-off-by: Modular Magician <[email protected]>
modular-magician
force-pushed
the
codegen-pr-2414
branch
from
d05c0eb to
290fdea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Author: @chrissng