Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure release channel when creating GKE clusters #2414

Merged
merged 15 commits into from
Oct 15, 2019
Merged

Configure release channel when creating GKE clusters #2414

merged 15 commits into from
Oct 15, 2019

Conversation

chrissng
Copy link
Contributor

@chrissng chrissng commented Oct 2, 2019

Allow the configuration of release channels when creating GKE clusters.

TODOs:

Release Note Template for Downstream PRs (will be copied)

Allow the configuration of release channels when creating GKE clusters.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@chrissng
Copy link
Contributor Author

chrissng commented Oct 3, 2019

This PR needs to be approved and merged first: hashicorp/terraform-provider-google-beta#1231

@rileykarson
Copy link
Member

Sorry for the drive-by comment, @slevenick will be the primary reviewer for this. I think release channels are gone GA: https://cloud.google.com/kubernetes-engine/docs/release-notes#september_16_2019

@chrissng
Copy link
Contributor Author

chrissng commented Oct 8, 2019

Hello @rileykarson, the release channel config is currently only available in the v1beta1 GKE REST API. I will keep track and use v1 when it becomes available.

https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1/projects.locations.clusters#Cluster

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9c9fc09.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1260
depends: hashicorp/terraform-provider-google#4671

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 385925a.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@slevenick
Copy link
Contributor

CI is failing due to this branch needing the vendored changes from your other branch. I'll cherry-pick and run tests manually, and if they work I'll go ahead and merge both PRs

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 385925a.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the addition!

Would be good to update this when the fields are available in the GA client

@slevenick
Copy link
Contributor

Ran into some issues during merging. Our git system doesn't function well if you merge master into your branch during development (each commit must be able to be applied to current master individually). I rebased on master and force pushed, but the diff should be identical (hopefully) and not create any downstreams

I'll merge assuming it all works and passes CI

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 947c68d.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1268
depends: hashicorp/terraform-provider-google#4684

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a787c22.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician modular-magician merged commit d2ba582 into GoogleCloudPlatform:master Oct 15, 2019
JanMa pushed a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
JanMa added a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants