-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure release channel when creating GKE clusters #2414
Configure release channel when creating GKE clusters #2414
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. Thanks for your contribution! A human will be with you soon. @slevenick, please review this PR or find an appropriate assignee. |
This PR needs to be approved and merged first: hashicorp/terraform-provider-google-beta#1231 |
Sorry for the drive-by comment, @slevenick will be the primary reviewer for this. I think release channels are gone GA: https://cloud.google.com/kubernetes-engine/docs/release-notes#september_16_2019 |
Hello @rileykarson, the release channel config is currently only available in the v1beta1 GKE REST API. I will keep track and use v1 when it becomes available. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
CI is failing due to this branch needing the vendored changes from your other branch. I'll cherry-pick and run tests manually, and if they work I'll go ahead and merge both PRs |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the addition!
Would be good to update this when the fields are available in the GA client
Ran into some issues during merging. Our git system doesn't function well if you merge master into your branch during development (each commit must be able to be applied to current master individually). I rebased on master and force pushed, but the diff should be identical (hopefully) and not create any downstreams I'll merge assuming it all works and passes CI |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
…loudPlatform#2414)" This reverts commit 482f093.
Allow the configuration of release channels when creating GKE clusters.
TODOs:
google_container_cluster
resource.Release Note Template for Downstream PRs (will be copied)