Deprecate convenience fields in google_compute_snapshot #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
paddycarver
reviewed
Dec 4, 2018
There was a problem hiding this comment.
I only commented on the CustomizeDiff stuff, and only for one resource, so far, because I feel like updating it once will update it everywhere, right? And also, that's what I was specifically asked to give feedback on.
A few minor points, but overall, I think the logic covers the cases well, and makes sense to me?
I'll continue reviewing the rest, I just wanted to surface this early.
modular-magician
force-pushed
the
codegen-pr-987
branch
from
49bbb99 to
62c5fa0
Compare
paddycarver
reviewed
Dec 4, 2018
|
Ah, nope - all of those were unintentional. Once the Magician is done they should be fixed. |
modular-magician
force-pushed
the
codegen-pr-987
branch
2 times, most recently
from
85100ad to
788fd3e
Compare
modular-magician
force-pushed
the
codegen-pr-987
branch
from
788fd3e to
a14dbad
Compare
paddycarver
approved these changes
Dec 5, 2018
nat-henderson
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
same comments as in hashicorp/terraform-provider-google#2572 (review) - once resolved, lgtm
modular-magician
force-pushed
the
codegen-pr-987
branch
from
a14dbad to
d95b0db
Compare
nat-henderson
pushed a commit
that referenced
this pull request
Dec 11, 2018
<!-- This change is generated by MagicModules. --> /cc @rileykarson
nat-henderson
pushed a commit
that referenced
this pull request
Dec 12, 2018
<!-- This change is generated by MagicModules. --> /cc @rileykarson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @rileykarson