-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate convenience fields in google_compute_snapshot #2572
Conversation
f5edadf
to
e962ca9
Compare
1f9fe27
to
067a257
Compare
067a257
to
a6b9f16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks reasonable to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels approximately right - two not-sure-about-it points.
a6b9f16
to
2008e01
Compare
<!-- This change is generated by MagicModules. --> /cc @rileykarson
<!-- This change is generated by MagicModules. --> /cc @rileykarson
<!-- This change is generated by MagicModules. --> /cc @rileykarson
<!-- This change is generated by MagicModules. --> /cc @rileykarson
<!-- This change is generated by MagicModules. --> /cc @rileykarson
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
/cc @rileykarson