Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/storage_account: parsing the account name from either casing #99

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

tombuildsstuff
Copy link
Contributor

Azure Stack 1905 changes the casing of the Resource ID such that it's now returned as storageAccounts rather than storageaccounts. So that we keep compatibility with both previous versions and the latest version of Azure Stack - this PR switches to trying to parse the name out of both possible casings.

Unfortunately the Azure Stack instance we use hasn't been updated to 1905, so I'm unable to confirm this directly, but I believe this should fix #90 - based on this comment

Fixes #90

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cblackuk cblackuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit ed30168 into master Jul 9, 2019
@tombuildsstuff tombuildsstuff deleted the b/storage-account-id branch July 9, 2019 04:26
tombuildsstuff added a commit that referenced this pull request Jul 9, 2019
@ghost
Copy link

ghost commented Jul 23, 2019

This has been released in version 0.8.1 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurestack" {
    version = "~> 0.8.1"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 8, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release 0.7.0, 0.8.0 of Azurestack Provider not compatible with AzureStack 1905/1906 --- wrong autorest ?
4 participants