Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.7.0, 0.8.0 of Azurestack Provider not compatible with AzureStack 1905/1906 --- wrong autorest ? #90

Closed
bottkars opened this issue Jun 15, 2019 · 18 comments · Fixed by #99
Milestone

Comments

@bottkars
Copy link

I all,
we recently moved to Azurestack 1905. i turns that some calls, specially storage, no longer work.

the error can be reproduced with the storage example
https://www.terraform.io/docs/providers/azurestack/r/storage_account.html

azurestack_storage_account.testsa: 1 error occurred:
* azurestack_storage_account.testsa: azurestack_storage_account.testsa: Error reading the state of AzurStack Storage Account "": storage.AccountsClient#GetProperties: Invalid input: autorest/validation: validation failed: parameter=accountName constraint=MinLength value="" details: value length must be greater than or equal to 3

@bottkars
Copy link
Author

bottkars commented Jun 15, 2019

was tested against asdk + integrated systems 1905 / 1906 from windows and linux

@bottkars bottkars changed the title relese 0.7.0 of Azurestack not compatible with 1905 release 0.7.0 of Azurestack not compatible with 1905 Jun 16, 2019
@jbmcfarlin31
Copy link

@bottkars Currently seeing this same error, although I am running version 0.6.0 of the provider on terraform version 0.11.14. We just recently upgraded our stack to the 1905 build also.

@LynxPantera
Copy link

Hi @bottkars, @jbmcfarlin31,
I also have the same problem with the new version 1905 build, I did the tests with Terraform 0.12.2 and the provider version 0.7.0.

@jbpaux
Copy link

jbpaux commented Jun 25, 2019

Can you try with the 0.8.0 released yesterday ?

@LynxPantera
Copy link

Hello @jbpaux,
I just did a new deployment test with Terraform 0.12.3 and the Azure Stack 0.8.0 provider and I still have the same problem.

@jselleck
Copy link

We tested with 0.8.0 and have the same issue.

@bottkars
Copy link
Author

Same here .

@jbpaux
Copy link

jbpaux commented Jun 28, 2019

In that case, can you rename the title of the issue to 0.8.0 too ?
I haven't had the change to try it yet. Strugling to try to auth with azure-cli token in a disconnected env (the one you came for in Paris @bottkars 🤣 ).

@DinoBordonaro
Copy link

I see the same with 0.8.0 and Azure Stack Release 1906 on my Multinode System

@bottkars bottkars changed the title release 0.7.0 of Azurestack not compatible with 1905 release 0.7.0 of Azurestack not compatible with 1905/1906 --- wrong autorest ? Jun 29, 2019
@bottkars bottkars changed the title release 0.7.0 of Azurestack not compatible with 1905/1906 --- wrong autorest ? release 0.7.0, 0.8.0 of Azurestack Provider not compatible with AzureStack 1905/1906 --- wrong autorest ? Jun 29, 2019
@wellsluo
Copy link

wellsluo commented Jul 8, 2019

Just want to check if there are any updates on this issue?

@cblackuk
Copy link
Contributor

cblackuk commented Jul 8, 2019

Would be awesome to know :-) so +1

@jbmcfarlin31
Copy link

Our primary resource handler is azure stack so this is hindering us quite a bit.. +1 on if there is any updates

@tombuildsstuff
Copy link
Contributor

👋

Thanks for opening this issue.

The Azure Stack instance that we have access to isn't currently running 1905 so we're not seeing this error in our tests unfortunately (but we're reaching out/working on this) - but taking a look into this (and comparing with AzureRM) I believe the casing on the Resource ID has changed for the Storage Account which means this is being parsed out as an empty string (which is why this errors being returned from the SDK).

Since unfortunately we don't have access to confirm that theory at this time (as our Azure Stack instance isn't running 1905) - so that we can diagnose this would anyone be able to confirm that the casing of the Resource ID segment storageaccounts has changed to storageAccounts using (for example) the Azure CLI on Azure Stack 1905?

Thanks!

@cblackuk
Copy link
Contributor

cblackuk commented Jul 8, 2019

@tombuildsstuff

ResourceGroupName      : system.xxxxxxxxx
StorageAccountName     : urphealthaccount
Id                     : /subscriptions/xxxxxx-xxxxx-xxxxx-xxxxx/resourcegroups/system.xxxxxxxx/providers/Microsoft.Storage/storageAccounts/urphealthaccount
Location               : xxxxxxxx
Sku                    : Microsoft.Azure.Management.Storage.Models.Sku
Kind                   : Storage
Encryption             : Microsoft.Azure.Management.Storage.Models.Encryption
AccessTier             :
CreationTime           : 01/02/2018 01:37:44
CustomDomain           : 
Identity               :
LastGeoFailoverTime    :
PrimaryEndpoints       : Microsoft.Azure.Management.Storage.Models.Endpoints
PrimaryLocation        : xxxxxxxx
ProvisioningState      : Succeeded
SecondaryEndpoints     :
SecondaryLocation      :
StatusOfPrimary        : Available
StatusOfSecondary      :
Tags                   :
EnableHttpsTrafficOnly : False
NetworkRuleSet         : 
Context                : Microsoft.WindowsAzure.Commands.Common.Storage.LazyAzureStorageContext
ExtendedProperties     : {}

So yeah ID is with uppercase A:

Id                     : /subscriptions/xxxxxx-xxxxx-xxxxx-xxxxx/resourcegroups/system.xxxxxxxx/providers/Microsoft.Storage/storageAccounts/urphealthaccount

I hope that helps.

On Tenant side - same thing.

@tombuildsstuff
Copy link
Contributor

@cblackuk thanks for confirming that - I believe #99 should fix this then 👍

@cblackuk
Copy link
Contributor

cblackuk commented Jul 8, 2019

Awesome!!! The PR looks legit, if that was the only issue it has got a chance to fix it :-)

Thanks @tombuildsstuff

@katbyte katbyte added this to the v0.8.1 milestone Jul 9, 2019
@ghost
Copy link

ghost commented Jul 23, 2019

This has been released in version 0.8.1 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurestack" {
    version = "~> 0.8.1"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 8, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
10 participants