Added resource for SQL MI "azurerm_sql_managed_instance"

[joranm]

New resource provider for SQL Managed Instance
https://docs.microsoft.com/en-us/azure/sql-database/sql-database-managed-instance

Known issues

• Destroys fails due to platform lease on Virtual Server Object (12 hours before it is deleted)

Fixes #1747

[joranm]

@katbyte , what is the issue with the megalinter? I'm seeing the same issue with PR #2716

[katbyte]

@joranm,

gometalinter removed some linters (megacheck and unused) as they were merged into staticcheck and we didn't pin the tooling version. As a result all linting was failing. It has been resolved in #2722 so merge/rebase on master and it should pass 🙂

[joranm]

Hi @katbyte, @tombuildsstuff , did a rebase, and tests have passed successfully.
Regarding the known issue. What would be the best approach?

1) Timeout issue on create (6 hours): Is it possible to implement the Timeout on these resources? I didn't found this feature implemented at any other resource.
2) Lock on dependend resources The creation of SQL Managed Instance does also create a Virtual Server Object and a Network Intent Policy, which locks the subnet and routetable. This object is automatically cleaned after 12 hours after the SQL MI instance removal.

[katbyte]

@joranm,

wrt 1 - at the moment we don't have timeouts implemented, that is something we plan to implement for v2.0 so until then tested this will be.. difficult. We have a few ideas but none are idea (an ENV for a pre existing subnet where a MI has already been provisioned for example)

[archmangler]

There is a suggestion on #1747 that the creation time has been greatly reduced on the AzureRM side. Has anyone tested if this improves the situation sufficiently to make this provider usable?

[pkaminski-degree]

Is this feature planned to be merged any time soon?

[jacobm3]

Any idea when this resource will be merged? Would love to see this available. Thanks!

[sarayho1]

Will this resource be merged and released anytime soon? Received a time-out error running the code with ARM JSON.

[TraGicCode]

Would be awesome to see more progress on getting this pushed through!

[WascawyWabbit]

Any news on when this will be merged?

[katbyte]

@joranm,

I went to run these tests today and got the following build error (as we have updated the azure go sdk)

==> Checking that code complies with gofmt requirements...
go install
# github.com/terraform-providers/terraform-provider-azurerm/azurerm
azurerm/resource_arm_sql_managed_instance.go:143:4: cannot use utils.String(licenseType) (type *string) as type "github.com/Azure/azure-sdk-for-go/services/preview/sql/mgmt/2015-05-01-preview/sql".ManagedInstanceLicenseType in field value
make: *** [build] Error 2

Went to merge master and push but it seems I can't? any chance you could update this se we could see if the instance provisions any faster now

[kim0]

I had opened #3593 and #3587 but apparently this is still WIP. If you have any questions, let me know though

[katbyte]

hi @kim0, the new PR is #3575 as this one seems to have been abandoned. Currently it is blocked with:

------- Stdout: -------
=== RUN   TestAccAzureRMSqlMiServer_basic
=== PAUSE TestAccAzureRMSqlMiServer_basic
=== CONT  TestAccAzureRMSqlMiServer_basic
--- FAIL: TestAccAzureRMSqlMiServer_basic (741.07s)
    testing.go:568: Step 0 error: errors during apply:
        
        Error: Code="VnetSubnetConflictWithIntendedPolicy" Message="Route Table. (https://go.microsoft.com/fwlink/?linkid=871071)"
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test102924249/main.tf line 40:
          (source code not available)
        
        
FAIL

so any help on how to resolve that would be fantastic as i am working on other things at the moment.

[joranm]

@joranm,
I went to run these tests today and got the following build error (as we have updated the azure go sdk)
==> Checking that code complies with gofmt requirements...
go install

github.com/terraform-providers/terraform-provider-azurerm/azurerm

azurerm/resource_arm_sql_managed_instance.go:143:4: cannot use utils.String(licenseType) (type *string) as type "github.com/Azure/azure-sdk-for-go/services/preview/sql/mgmt/2015-05-01-preview/sql".ManagedInstanceLicenseType in field value
make: *** [build] Error 2

Went to merge master and push but it seems I can't? any chance you could update this se we could see if the instance provisions any faster now

Hi @katbyte,
Provisioning of the first SQL MI in a vnet still takes between 6 and 12 hours. A lot of plumbing is done at the Azure side with regard to building a 5 node cluster, sql data gateway, loadbalancers and so on. I don't expect that the provisioning will be faster in the near future. Is it possible to implement the "timeout" property for Azure resources?

[katbyte]

@joranm, I believe that is in the works for v2.0 of the provider

[katbyte]

If you could pull in the changes from the PR i opened and or grant us push access to this branch we can take it from here

[tombuildsstuff]

Provisioning of the first SQL MI in a vnet still takes between 6 and 12 hours.

@joranm

Indeed, it's better than it was (36h) but it still takes a while; chatting with the SQL Team a while back it turns out there's multiple conditions where the Create/Update call could take this long:

• when the cluster this is using under the hood within the subnet is initially built (as you're seeing)
• when the cluster is scaled up (for every 5 or so instances/databases within the same subnet)
• when the cluster is scaled down (for every 5 or so instances/databases within the same subnet)

Is it possible to implement the "timeout" property for Azure resources?

As @katbyte has mentioned this is something we're doing as a part of the 2.0 release - at this point in time we're working on the dependencies to make that possible (we're working on switching out the Azure Storage SDK at the moment) at which point we should be able to enable Timeout support. However since this requires the Timeout support/this is going to ship in the 2.0 timeframe - I'm going to add this to the 2.0 milestone.

[sheigel]

A few weeks ago a smaller number of vcores (4) was introduced:
https://docs.microsoft.com/en-us/azure/sql-database/sql-database-managed-instance-resource-limits#instance-level-resource-limits

It seems worthwhile to have this new resource up to date.

[katbyte]

Hi @joranm, i'm going to close this as @mbfrahry has started to move this forward in #5399

[ghost]

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!