linting: update to work with new staticcheck #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katbyte
changed the title
katbyte
changed the title
metacpp
approved these changes
Jan 22, 2019
staticcheck.conf
Outdated
| "URL", "UTF8", "VM", "XML", "XMPP", "XSRF", | ||
| "XSS"] | ||
| dot_import_whitelist = [] | ||
| http_status_code_whitelist = ["200", "400", "404", "500"] |
rileykarson
added a commit
to hashicorp/terraform-provider-google
that referenced
this pull request
Feb 5, 2019
This isn't working locally, but it matches the changes made in hashicorp/terraform-provider-azurerm#2722 so maybe something freaky is going on and it will only work in CI? Edit: This only works in CI (well, at least doesn't work locally for *me*) but the same is true in the Azure provider. Most of those rules can be turned back on provided we make the corresponding code changes, but let's bring back `unused` for now. I'll dupe over to tpgb on approval.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
megacheck and unused are now part of staticcheck