Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reboot a VM only on managed disk resize #6162

Merged
merged 5 commits into from
Mar 25, 2020

Conversation

shurikk
Copy link
Contributor

@shurikk shurikk commented Mar 18, 2020

related to #6063

Fixes #6063

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @shurikk

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can fix up the documentation issue (and the tests pass) then this otherwise LGTM 👍

Thanks!

website/docs/r/managed_disk.html.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @shurikk

@tombuildsstuff
Copy link
Contributor

hey @shurikk

Thanks for this PR - I've spent a little time digging into this and it appears there's some more edge-cases here - as such I hope you don't mind but I'm going to push a couple of commits to rebase this PR (to include the changes from #6207) and then handle those edge-cases so that we can get this merged.

Thanks!

@tombuildsstuff tombuildsstuff force-pushed the only-reboot-on-disk-resize branch from 6e21752 to e4aab7a Compare March 24, 2020 09:34
@ghost ghost added size/L and removed size/XS labels Mar 24, 2020
@tombuildsstuff tombuildsstuff force-pushed the only-reboot-on-disk-resize branch from e4aab7a to 3765f32 Compare March 24, 2020 09:35
@tombuildsstuff tombuildsstuff removed their assignment Mar 24, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shurikk
Copy link
Contributor Author

shurikk commented Mar 24, 2020

thanks 👍

@tombuildsstuff
Copy link
Contributor

Ignoring one test failing due to capacity issues in Azure - the tests pass:

Screenshot 2020-03-24 at 18 01 19

@tombuildsstuff tombuildsstuff merged commit 9ff4a7e into hashicorp:master Mar 25, 2020
tombuildsstuff added a commit that referenced this pull request Mar 25, 2020
@shurikk shurikk deleted the only-reboot-on-disk-resize branch March 25, 2020 16:54
@shurikk
Copy link
Contributor Author

shurikk commented Mar 25, 2020

any chance this fix goes into 1.xx branch? I know that 1.44 was the last one in 1.xx, this bug is somewhat dangerous.

@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changing azurerm_managed_disk disk tags causes VM reboot
3 participants