-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azurerm_managed_disk.disk_encryption_set_id without recreating the resource #6207
Update azurerm_managed_disk.disk_encryption_set_id without recreating the resource #6207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kazimierzbudzyk,
thanks for the PR, could we add a test that changes the encryption id & update the docs? thanks!
Thank you for the review @katbyte! Applied requested changes, let me know if you have any other comments! |
3ba2372
to
28a53a4
Compare
28a53a4
to
3be60e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this @kazimierzbudzyk
dismissing since changes have been pushed
(Tests look fine) |
This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.3.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixes: #6184
CMK encryption can be enabled without recreating (requires VM to be stopped): https://docs.microsoft.com/en-us/azure/virtual-machines/linux/disk-encryption#enable-on-an-existing-disk