Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_kusto_cluster - support for enable_disk_encryption and enable_streaming_ingest #5855

Merged
merged 9 commits into from
Mar 2, 2020
Merged

azurerm_kusto_cluster - support for enable_disk_encryption and enable_streaming_ingest #5855

merged 9 commits into from
Mar 2, 2020

Conversation

aqche
Copy link
Contributor

@aqche aqche commented Feb 24, 2020

Fixes #5713

Adds the enable_disk_encryption option to the azurerm_kusto_cluster resource.

--- PASS: TestAccAzureRMKustoCluster_basic (1533.92s)
--- PASS: TestAccAzureRMKustoCluster_withTags (1959.20s)
--- PASS: TestAccAzureRMKustoCluster_sku (2519.03s)
--- PASS: TestAccAzureRMKustoCluster_enableDiskEncryption (2896.44s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/kusto/tests 2896.565s

@ghost ghost added size/M and removed size/S labels Feb 25, 2020
@aqche aqche changed the title azurerm_kusto_cluster - support for enable_disk_encryption azurerm_kusto_cluster - support for enable_disk_encryption and enable_streaming_ingest Feb 25, 2020
@aqche
Copy link
Contributor Author

aqche commented Feb 25, 2020 •
edited
Loading

updated to include the work by @njuCZ in PR #5858 adding the enable_streaming_ingest option

--- PASS: TestAccAzureRMKustoCluster_basic (1897.19s)
--- PASS: TestAccAzureRMKustoCluster_withTags (1989.38s)
--- PASS: TestAccAzureRMKustoCluster_sku (2444.75s)
--- PASS: TestAccAzureRMKustoCluster_propsUpdate (2463.38s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/kusto/tests 2464.766s

katbyte
katbyte requested changes Feb 26, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @aqche,

Overall this looks great, i've left some minor comment sinline mostly around testing that once addressed this should be good to go!

azurerm/internal/services/kusto/resource_arm_kusto_cluster.go Outdated Show resolved Hide resolved
azurerm/internal/services/kusto/tests/resource_arm_kusto_cluster_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/kusto/tests/resource_arm_kusto_cluster_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/kusto/tests/resource_arm_kusto_cluster_test.go
@@ -30,6 +30,35 @@ func TestAccAzureRMKustoCluster_basic(t *testing.T) {
})
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a complete test here as described before

azurerm/internal/services/kusto/tests/resource_arm_kusto_cluster_test.go
resource.TestCheckResourceAttr(data.ResourceName, "enable_streaming_ingest", "false"),
),
},
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could wedo an import check here

azurerm/internal/services/kusto/tests/resource_arm_kusto_cluster_test.go
),
},
data.ImportStep(),
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then here go back to basic

@aqche
Copy link
Contributor Author

aqche commented Feb 27, 2020

@katbyte thanks for the review! made the changes you suggested.

=== RUN   TestAccAzureRMKustoCluster_update
=== PAUSE TestAccAzureRMKustoCluster_update
=== CONT  TestAccAzureRMKustoCluster_update
--- PASS: TestAccAzureRMKustoCluster_update (3277.49s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/kusto/tests 3277.525s

katbyte
katbyte approved these changes Mar 2, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions @aqche! LGTM now 👍

@katbyte katbyte added this to the v2.1.0 milestone Mar 2, 2020
@katbyte katbyte merged commit 487306f into hashicorp:master Mar 2, 2020
katbyte added a commit that referenced this pull request Mar 2, 2020
@katbyte
Update CHANGELOG.md to include #5855
d7b0681
@aqche aqche deleted the azurerm_kusto_cluster_enable_disk_encryption branch March 2, 2020 04:19
@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/kusto size/M
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

Support for enabling encryption in azurerm_kusto_cluster
3 participants
@aqche @katbyte @njuCZ