Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for enabling encryption in azurerm_kusto_cluster #5713

Closed
patrickbsf opened this issue Feb 12, 2020 · 4 comments · Fixed by #5855
Closed

Support for enabling encryption in azurerm_kusto_cluster #5713

patrickbsf opened this issue Feb 12, 2020 · 4 comments · Fixed by #5855

Comments

@patrickbsf
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The azurerm_kusto_cluster resource needs to allow cluster encryption to be enabled.

Based on other settings in azurerm resources which follow the pattern of enable_xx_encryption = true|false, something like:
enable_cluster_encryption = true
or simply:
enable_encryption = true (since it's already in the cluster resource definition)
would be fine.

Currently, you have to enable it manually after creating the cluster through terraform.
There may be other options like this that aren't currently exposed in this resource, but this is what stands out to me right now.

New or Affected Resource(s)

  • azurerm_kusto_cluster

Potential Terraform Configuration

resource "azurerm_kusto_cluster" "cluster" {
  name = var.name
  location  = var.location
  resource_group_name = var.resource_group_name

  enable_encryption = true

  sku {
    capacity = 2
    name     = "Standard_D11_v2"
  }
}

References

@aqche
Copy link
Contributor

aqche commented Feb 24, 2020

I can take a look into getting a PR up for this!

@njuCZ
Copy link
Contributor

njuCZ commented Feb 24, 2020

@aqche I am sorry it seems I have made a duplicate work...... I will close my PR. And would you mind to add more fields support in your PR: such as enable_streaming_ingest

@aqche
Copy link
Contributor

aqche commented Feb 25, 2020

Sorry @njuCZ, I didn't mean to end up overlapping my work with yours. I'll pull your commits into my PR to make sure the effort you put in will be included!

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants