Support for Azure File Share backup #5213
Conversation
While this property is accepted by the Azure API and is in their documentation, it seems to be ignored and is not returned on subsequent GET requests
There was a problem hiding this comment.
Hi @sean-nixon,
Thanks for the PR! overall this looks great, however i've left a few minor comments left inline that should be addressed before merge. a FYI we are planning on doing a large refactor that will impact all open PRs shortly and it doesn't seem like i was able to push changes to this branch/
| _, err = resourceArmBackupProtectionContainerStorageAccountWaitForOperation(ctx, opStatusClient, vaultName, resGroup, operationID, d) | ||
| if err != nil { |
There was a problem hiding this comment.
these two lines can be merged
| _, err = resourceArmBackupProtectionContainerStorageAccountWaitForOperation(ctx, opClient, vaultName, resGroup, operationID, d) | ||
| if err != nil { |
There was a problem hiding this comment.
Can these two lines be merged?
|
@katbyte I've updated the PR with most of your suggestions. In regards to the comments on code accounting for Azure/azure-sdk-for-go#2824 (comment), I am still seeing this issue locally for every resource included here. Assuming it's fixed, I'm guessing an SDK upgrade would be required in order to incorporate the fix? What's the process for that? |
There was a problem hiding this comment.
@sean-nixon, thanks for checking. It could have only been fixed for a couple of the endpoints or require a new API version. Either way this looks great now! thanks for the revisions and i'll merge it once the tests finish
|
This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.40.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Addresses #5026
An additional resource beyond the suggested resources in the associated issue was required in order to first register a storage account with a recovery services vault. I've also used an updated naming scheme based on my proposal in #5089 and associated PR #5170 in order to better distinguish Azure Backup resources from Site Recovery (DR) resources. That PR does not technically block this one, but it would make the naming more consistent with the existing Azure Backup resources.
This is my first PR creating totally new resources and I'm pretty new to Go so I'm very open to feedback on style and conventions.
API Docs:
https://docs.microsoft.com/en-us/rest/api/backup/protecteditems
https://docs.microsoft.com/en-us/rest/api/backup/protectioncontainers
https://docs.microsoft.com/en-us/rest/api/backup/protectionpolicies