Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Azure files backup in Recovery Service Vault #5026

Closed
Oicho opened this issue Nov 29, 2019 · 3 comments
Closed

Support for Azure files backup in Recovery Service Vault #5026

Oicho opened this issue Nov 29, 2019 · 3 comments

Comments

@Oicho
Copy link

Oicho commented Nov 29, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently azure files in recovery service vault is in preview and should soon be in GA. Currently terraform does not support this.

New or Affected Resource(s)

  • azurerm_recovery_services_vault
  • azurerm_storage_share

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.
resource "azurerm_recovery_services_protection_policy_file_share" "" {
  name                = "fs-recovery-vault-policy"
  resource_group_name = "${azurerm_resource_group.example.name}"
  recovery_vault_name = "${azurerm_recovery_services_vault.example.name}"

  timezone = "UTC"

  backup {
    time      = "23:00"
  }

  retention_range = 10
}

resource "azurerm_recovery_services_protected_file_share" "XXXX" {
  resource_group_name = "${azurerm_resource_group.example.name}"
  recovery_vault_name = "${azurerm_recovery_services_vault.example.name}"
  source_storage_account_id        = "${azurerm_virtual_machine.example.id}"
  source_file_share_name = "share1"
  backup_policy_id    = "${azurerm_recovery_services_protection_policy_vm.example.id}"
}

References

katbyte pushed a commit that referenced this issue Dec 19, 2019
Addresses #5026

An additional resource beyond the suggested resources in the associated issue was required in order to first register a storage account with a recovery services vault. I've also used an updated naming scheme based on my proposal in #5089 and associated PR #5170 in order to better distinguish Azure Backup resources from Site Recovery (DR) resources. That PR does not technically block this one, but it would make the naming more consistent with the existing Azure Backup resources.
@katbyte katbyte added this to the v1.40.0 milestone Dec 19, 2019
@tombuildsstuff
Copy link
Contributor

fixed via #5213 - thanks @sean-nixon :)

@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants