Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_arm_network_interface.go: Fixes #4721 #4852

Merged
merged 1 commit into from
Nov 17, 2019
Merged

resource_arm_network_interface.go: Fixes #4721 #4852

merged 1 commit into from
Nov 17, 2019

Conversation

NilsBusche
Copy link
Contributor

@NilsBusche NilsBusche commented Nov 11, 2019

This fixes the bug mentioned in #4721.

private_ip_address was only filled if allocation method was Static. With this pull request it will be filled also if allocation method is set to Dynamic. This is corresponding to the behaviour of the Azure API, which always displays the private IP addresses.

Fixes #4721

@ghost ghost added the size/XS label Nov 11, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @NilsBusche

@tombuildsstuff tombuildsstuff added this to the v1.37.0 milestone Nov 17, 2019
@tombuildsstuff tombuildsstuff merged commit a6139e2 into hashicorp:master Nov 17, 2019
tombuildsstuff added a commit that referenced this pull request Nov 17, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

private_ip_address not filled in azurerm_network_interface resource and datasource
2 participants