Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support app service HTTP blob logging #4249

Merged

Conversation

phekmat
Copy link
Contributor

@phekmat phekmat commented Sep 5, 2019

This PR is an extension of #3520 (and works toward #1082), adding blob support for the HTTP logs

- Remove the `WEBSITE_HTTPLOGGING*` settings from the app settings when
reading the app service. Those app settings are handled by Azure via the
`http_logs` block
- Add `azure_blob_storage` to `http_logs` for `azurerm_app_service` to
mirror the functionality for the application logs. Unlike the app logs,
Azure only supports a single destination for the web logs and doesn't
support different log levels
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @phekmat

Thanks for this PR - taking a look through this LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-09-06 at 12 20 43

@tombuildsstuff
Copy link
Contributor

Accidentally hit close rather than comment, sorry 🤦‍♂

@tombuildsstuff tombuildsstuff merged commit 604fa22 into hashicorp:master Sep 6, 2019
tombuildsstuff added a commit that referenced this pull request Sep 6, 2019
@phekmat phekmat deleted the feature/app_service_http_blob_logging branch September 11, 2019 13:14
@sorenhansendk
Copy link

@phekmat Thank you for the PR. I have tested it on the resource type azurerm_app_service today and it works fine. Will it be possible to add the same settings to the azurerm_app_service_slot resource type?

@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@phekmat
Copy link
Contributor Author

phekmat commented Oct 1, 2019

@sorenhansendk I just created #4473 for that

@ghost
Copy link

ghost commented Oct 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants