-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support app service HTTP blob logging #4249
Support app service HTTP blob logging #4249
Conversation
- Remove the `WEBSITE_HTTPLOGGING*` settings from the app settings when reading the app service. Those app settings are handled by Azure via the `http_logs` block
- Add `azure_blob_storage` to `http_logs` for `azurerm_app_service` to mirror the functionality for the application logs. Unlike the app logs, Azure only supports a single destination for the web logs and doesn't support different log levels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @phekmat
Thanks for this PR - taking a look through this LGTM 👍
Accidentally hit close rather than comment, sorry 🤦♂ |
@phekmat Thank you for the PR. I have tested it on the resource type |
This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.34.0"
}
# ... other configuration ... |
@sorenhansendk I just created #4473 for that |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This PR is an extension of #3520 (and works toward #1082), adding blob support for the HTTP logs