Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support log settings for app service slot #4473

Conversation

phekmat
Copy link
Contributor

@phekmat phekmat commented Oct 1, 2019

This PR is an extension of #4249 & #3520 (and works toward #1082), adding diagnostic and HTTP log settings support for the slot

- Support sending the slot diagnostic logs to blob storage
- Support sending the slot HTTP logs to blob storage and the filesystem
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @phekmat

@tombuildsstuff tombuildsstuff added this to the v1.35.0 milestone Oct 2, 2019
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-10-02 at 07 58 12

@tombuildsstuff tombuildsstuff merged commit d545a47 into hashicorp:master Oct 2, 2019
tombuildsstuff added a commit that referenced this pull request Oct 2, 2019
@ghost
Copy link

ghost commented Oct 4, 2019

This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.35.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants