azurerm_virtual_machine: add support for Ultra SSD's to the managed_disk_type property

[venkey1000]

added ultra ssd support for azure
steps:

1. added additionalCapabilitites with ultra_ssd_enabled field
2. added storage_data_disk with managed_disk_type as UltraSSD_LRS

PS:
Azure guys has given our subscription capability to attach ultra ssd disk, that is how we abled to test the feature

[tombuildsstuff]

hey @venkey1000

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can add documentation for this field this otherwise LGTM 👍

Thanks!

[tombuildsstuff]

hey @venkey1000

Thanks for pushing those changes - if we can add in the final link (and the tests pass) then this otherwise LGTM 👍

[katbyte]

Hi @venkey1000,

Thank you for the additional docs, could we add this to a new additional_capabilities test to ensure its set/readback/imported correctly?

[venkey1000]

Hi @venkey1000,

Thank you for the additional docs, could we add this to a new additional_capabilities test to ensure its set/readback/imported correctly?

Hi @katbyte
Sorry for the late reply.
I have added test cases for additional_capabilities in resource_arm_virtual_machine_unmanaged_disks_test.go.

[tombuildsstuff]

hey @venkey1000

Thanks for pushing those changes - taking a look through I spotted another couple of comments (and one question about the schema design) that I think need to be resolved before we can merge this; but this is otherwise looking good 👍

Thanks!

[venkey1000]

@venkey1000,

running the tests i am getting:

------- Stdout: -------
=== RUN   TestAccAzureRMVirtualMachine_additionalCapabilities
=== PAUSE TestAccAzureRMVirtualMachine_additionalCapabilities
=== CONT  TestAccAzureRMVirtualMachine_additionalCapabilities
--- FAIL: TestAccAzureRMVirtualMachine_additionalCapabilities (115.11s)
    testing.go:568: Step 0 error: errors during apply:
        
        Error: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidParameter" Message="UltraSSD can be used only with Virtual Machine in an Availability Zone." Target="additionalCapabilities.ultraSSDEnabled"
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test832387319/main.tf line 52:
          (source code not available)
        
        
FAIL

so you might need to adjust your test configuration

Hi @katbyte
I have updated test case for this feature, please have a look at it.

[katbyte]

@normseq & @venkey1000,

I am now getting quota errors in west europe:

------- Stdout: -------
=== RUN   TestAccAzureRMVirtualMachine_additionalCapabilities
=== PAUSE TestAccAzureRMVirtualMachine_additionalCapabilities
=== CONT  TestAccAzureRMVirtualMachine_additionalCapabilities
--- FAIL: TestAccAzureRMVirtualMachine_additionalCapabilities (151.65s)
    testing.go:568: Step 0 error: errors during apply:
        
        Error: Code="OperationNotAllowed" Message="Operation results in exceeding quota limits of UltraSSDDiskSizeInGB. Maximum allowed: 0, Current in use: 0, Additional requested: 68719476736. Please read more about quota increase at http://aka.ms/corequotaincrease."
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test276565280/main.tf line 33:
          (source code not available)
        
        
FAIL

[katbyte]

And switching to eastus2 i get:

------- Stdout: -------
=== RUN   TestAccAzureRMVirtualMachine_additionalCapabilities
=== PAUSE TestAccAzureRMVirtualMachine_additionalCapabilities
=== CONT  TestAccAzureRMVirtualMachine_additionalCapabilities
--- FAIL: TestAccAzureRMVirtualMachine_additionalCapabilities (88.90s)
    testing.go:568: Step 0 error: errors during apply:
        
        Error: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="BadRequest" Message="Storage Account type 'UltraSSD_LRS' is not supported in availability zone '3'."
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test059273537/main.tf line 33:
          (source code not available)
        
        
FAIL

[venkey1000]

And switching to eastus2 i get:

------- Stdout: -------
=== RUN   TestAccAzureRMVirtualMachine_additionalCapabilities
=== PAUSE TestAccAzureRMVirtualMachine_additionalCapabilities
=== CONT  TestAccAzureRMVirtualMachine_additionalCapabilities
--- FAIL: TestAccAzureRMVirtualMachine_additionalCapabilities (88.90s)
    testing.go:568: Step 0 error: errors during apply:
        
        Error: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="BadRequest" Message="Storage Account type 'UltraSSD_LRS' is not supported in availability zone '3'."
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test059273537/main.tf line 33:
          (source code not available)
        
        
FAIL

@katbyte can you share the resource(vm and subscription id) details you are trying to launch so that Azure team can debug the issue?

[normseq]

@katbyte Even in EastUS, UltraSSD will not be available in all availability zones.
For your subscription, can you please run the following?
CLI: az vm list-skus --resource-type disks --query "[?name=='UltraSSD_LRS'].locationInfo"

This will give you info on the AZ to use while creating an UltraSSD based VM specifically for your subscription.
Please try creating an UltraSSD enabled VM directly in the Azure Portal/CLI before trying with the provider so that we can confirm if its a whitelisting issue or provider code issue.
For more info, please check
https://docs.microsoft.com/en-us/azure/virtual-machines/windows/disks-enable-ultra-ssd

[katbyte]

@normseq, @venkey1000

If that is the case we are going to have to update the test to use availability zones and the new compute SKUs resource once its merged.

[katbyte]

@normseq & @venkey1000, has something changed with this moving to GA? When i attempt to run the test now i am getting:

 Error: Code="OperationNotAllowed" Message="Operation results in exceeding quota limits of UltraSSDDiskSizeInGB. Maximum allowed: 0, Current in use: 0, Additional requested: 68719476736. Please read more about quota increase at http://aka.ms/corequotaincrease."     

and i don't see anywhere in the portal to request an increase

[normseq]

@katbyte Though Ultra Disk Storage is now GA, one still needs to fill up a form (separate from the usual portal quota request) to get access to Ultra Disks. Are you trying to create a disk in your subscription which was already whitelisted?
https://azure.microsoft.com/en-us/blog/announcing-the-general-availability-of-azure-ultra-disk-storage/
https://aka.ms/UltraDiskSignup

[normseq]

@katbyte Were you able to provision an Ultra Disk directly using CLI in your subscription? If that goes through, the provider should go through.

[venkey1000]

Hi @katbyte i am unable to figure out the issue in website test, can you please point me to the issue why it is failing if possible.

[katbyte]

@venkey1000,

Hope you don't mind but i pushed the required changes so i could merge this. LGTM now 👍

[venkey1000]

@venkey1000,

Hope you don't mind but i pushed the required changes so i could merge this. LGTM now 👍

@katbyte.. Thank you so much :)

[ghost]

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!