Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_virtual_machine
: add support for Ultra SSD's to themanaged_disk_type
property #3860azurerm_virtual_machine
: add support for Ultra SSD's to themanaged_disk_type
property #3860Changes from 5 commits
f8394d6
9a91e81
be125a5
04d1ac2
ac41960
731c0d1
927be40
ef97eec
9fe3af2
1ffeafb
f73f0d7
d80ca15
433892d
b068ba0
5b88385
8601679
a221d6f
9ff0fd9
0da7390
f567c52
d294f47
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add the instructions someone needs to follow to enabled this on their subscription here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UltraSSD whitelisting is only a temporary measure since the feature is in preview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THe docs should contain all information required for a user to use this feature, temporary or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katbyte Sure, we can go ahead and get this added
"Currently, ultra SSDs are in preview and you must enroll (https://aka.ms/UltraSSDPreviewSignUp) in the preview in order to access them."
One small problem though is that once this feature is GA, this doc would have to be updated again. Alternatively, we could update the above line and add that 'Once the feature is GA, enrolment would not be required to use this feature".
Also, got a confirmation that the subscription ID's you submitted have been whitelisted for UltraSSD. Can you please confirm if you are able to test now?
@venkey1000 Can you also add a reference the article
https://docs.microsoft.com/en-us/azure/virtual-machines/windows/disks-enable-ultra-ssd