Upgrading to v11 of the Azure SDK for Go

[tombuildsstuff]

Upgrading to v11 of the Azure SDK for Go

• Vendoring v11.0.0-beta of the Azure SDK
• State Migrations for:
  • Container Registry
    • Basic SKU -> Classic
    • State Migration Storage Account Name & Key -> Storage Account ID
  • Key Vault
    • certificate_permissions All -> every option
    • key_permissions All -> every option
    • secret_permissions All -> every option
  • ServiceBus Namespace
    • Remove capacity if not a premium sku
• Pending issues:
  • Traffic Manager API version used in the SDK isn't available fixed
  • Container Registry API version used in the SDK isn't available fixed
• Ensure all breaking changes are updated in the Documentation

Changes and Deprecation Notices:

• azurerm_automation_account - the SKU Free has been replaced with Basic.
• azurerm_container_registry - Azure has updated the SKU from Basic to Classic, with new Basic, Standard and Premium SKU's introduced.
• azurerm_container_registry - the storage_account block is now storage_account_id and is only required for Classic SKU's
• azurerm_key_vault - certificate_permissions, key_permissions and secret_permissions have all had the All option removed by Azure. Each permission now needs to be specified manually.
• azurerm_servicebus_namespace - The capacity field can only be set for Premium SKU's
• azurerm_servicebus_queue - The enable_batched_operations and support_ordering fields have been deprecated by Azure.
• azurerm_servicebus_subscription - The dead_lettering_on_filter_evaluation_exceptions has been removed by Azure.
• azurerm_servicebus_topic - The enable_filtering_messages_before_publishing field has been removed by Azure.

[tombuildsstuff]

Taking a look into this - there's enough breaking changes that this is going to take some time - as such I'm going to park this PR for the moment.

[tombuildsstuff]

I'm just kicking off the full test suite now - but I need to do a ton of checking of the state migrations next

[tombuildsstuff]

It appears the Traffic Manager SDK is broken as the API version used isn't rolled out in Azure at the moment - opened an issue on the SDK repository: Azure/azure-sdk-for-go#794

[tombuildsstuff]

Container Registry's broken too: Azure/azure-sdk-for-go#795

[tombuildsstuff]

This PR will allow the following to be implemented: #272 #339

[mbfrahry]

I have a question about a comment and then the following code snippet. Other than that, this looks really good. Nice job Tom

[mbfrahry]

I might be reading this wrong but I just want to confirm based on your comment that premium has max size * 16

[tombuildsstuff]

this has been around for a while - so it hasn't changed AFAIK

[vancluever]

🎉 great job @tombuildsstuff!!!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!