Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add the accelerated networking in the azurerm_virtual_machine resource. #272

Closed
hashibot opened this issue Aug 25, 2017 · 8 comments

Comments

@hashibot
Copy link

This issue was originally opened by @uj7380 as hashicorp/terraform#15914. It was migrated here as a result of the provider split. The original body of the issue is below.


I have to create VM using enable accelerated networking.
But, I can't create it as it's can be enabled networking in the azurerm_virtual_machine resource. provider of terraform. Because of this issue, I'm using by creating network interface in the azurerm_template_deployment of terraform.
When can I use it in the terraform? If I can configure it now, Please inform me of how to enable it.

@tombuildsstuff
Copy link
Contributor

Hey @uj7380

Thanks for opening this issue :)

This currently isn't supported in Terraform and after some investigation will need an update to the Azure SDK for Go for us to be able to implement this. I've opened an issue requesting that this feature is added to the SDK and once it is we can look into adding support for it.

Thanks!

@uj7380
Copy link

uj7380 commented Dec 26, 2017

Please inform me of the current status. When will this feature be added? :)

@mattpound808
Copy link

Can we get an update on this please ?

Accelerated networking seems to have gone GA https://azure.microsoft.com/en-gb/blog/maximize-your-vm-s-performance-with-accelerated-networking-now-generally-available-for-both-windows-and-linux/ so it would be good to make use of it.

Thank you

Matt

@jzampieron
Copy link
Contributor

I had an immediate need for this feature. PR provided above.

I did a quick test with my account and it successfully provisioned a VM with the Melanox interface live and running.

I am not able to run the acceptance test suite, but I did provide what looked like a reasonable acceptance test.

@whytoe
Copy link
Contributor

whytoe commented May 3, 2018

@tombuildsstuff should this be closed?

resource "azurerm_network_interface" "nic01" {
name = "${var.vm_machine_name}nic01"
location = "${var.vm_location}"
resource_group_name = "${var.resource_group_name}"
network_security_group_id = "${var.nsg_id}"
enable_accelerated_networking = "True"

https://www.terraform.io/docs/providers/azurerm/d/network_interface.html#enable_accelerated_networking

@katbyte
Copy link
Collaborator

katbyte commented May 10, 2018

Hi @whytoe,

You are correct! Accelerated networking was added in version 1.0.1 of the provider @uj7380 @mattpound808

Thank you for pointing this out 🙂

@katbyte katbyte closed this as completed May 10, 2018
@lambodar
Copy link

lambodar commented May 20, 2019

How to enable accelerated networking in VMSS using Terraform. I tried enable_accelerated_networking = "True" in network profile but TF is complaining invalid or unknown key, am I missing anything? Any help is highly appreciable.

this is what I tried
............................

network_profile {
    name                      = "vmss_pf_profile"
    primary                   = true
    network_security_group_id = "${var.nsg}"
    enable_accelerated_networking = true

    ip_configuration {
      name                                   = "${var.name}"
      subnet_id                              = "${var.app_subnet}"
      primary                                = true
      load_balancer_backend_address_pool_ids = ["${var.azurerm_lb_backend_address_pool_id}"]
    }
  }

............................

@ghost
Copy link

ghost commented May 20, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants