New resource: DevSpace Controller for AKS cluster #2086
Conversation
Introduce pacakge for devspace controller.
…or DevSpaces controll… Add code to support creation of DevSpaces controller.
Implemented RUD operations for devspaces controller.
…ontroller. Add doc and test for DevSpace controller, and refine the schema.
metacpp
changed the title
metacpp
changed the title
Sku is set to be required and update doc.
For styling issue for devspace controller.
Update tests and styling code for DevSpace controller.
|
Test passed |
| } | ||
|
|
||
| var result devspaces.Controller | ||
| if result, err = future.Result(client); err != nil { |
There was a problem hiding this comment.
Could we use client.Get() here instead like the majority of other resources?
There was a problem hiding this comment.
Is this the new pattern for async API ?
There was a problem hiding this comment.
I wouldn't call it new, most resources are coded that way. There are only 3 places in the entire provider where future.result() is called
|
also, the provider is now on |
Co-Authored-By: metacpp <[email protected]>
…rovider-azurerm into devspace
…re function to fetch result.
@katbyte The PR is updated by resolving all issues. |
|
tests pass: |
|
@tombuildsstuff I followed up your suggestions in #2182 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
This PR is a follow up on #1488 to add DevSpace controller resource for AKS cluster.