Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring] Devspace Controller #2182

Merged
merged 11 commits into from
Oct 31, 2018
Merged

[Refactoring] Devspace Controller #2182

merged 11 commits into from
Oct 31, 2018

Conversation

metacpp
Copy link
Contributor

@metacpp metacpp commented Oct 29, 2018

Follow up the suggestions in #2086 by @tombuildsstuff .

@metacpp
♻️ (DevSpace) Follow up Tom's suggestions on PR#2086
bdaa835 
Add more validations and nil check in devspace.
@ghost ghost added the size/M label Oct 29, 2018
@metacpp metacpp requested review from JunyiYi and WodansSon October 29, 2018 22:35
@metacpp metacpp mentioned this pull request Oct 29, 2018
Merged
@tombuildsstuff tombuildsstuff removed the request for review from JunyiYi October 30, 2018 08:36
tombuildsstuff
tombuildsstuff suggested changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor things to fix but this otherwise LGTM 👍

azurerm/resource_arm_devspace_controller.go Outdated Show resolved Hide resolved
azurerm/resource_arm_devspace_controller.go Outdated Show resolved Hide resolved
website/docs/r/devspace_controller.html.markdown Outdated Show resolved Hide resolved
website/docs/r/devspace_controller.html.markdown Outdated Show resolved Hide resolved
website/docs/r/devspace_controller.html.markdown Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the 1.18.0 milestone Oct 30, 2018
@metacpp metacpp changed the title Refactoring devspace code [Refactoring] Devspace Controller Oct 30, 2018
@metacpp
Copy link
Contributor Author

metacpp commented Oct 30, 2018

@tombuildsstuff Thanks for the reviewing, all the issues are addressed but with some minor questions in the replies.

tombuildsstuff
tombuildsstuff approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @metacpp

Thanks for pushing those changes - this now LGTM 👍

Thanks!

@tombuildsstuff tombuildsstuff merged commit 206ff8a into master Oct 31, 2018
@tombuildsstuff tombuildsstuff deleted the devspace_refactor branch October 31, 2018 13:34
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@katbyte katbyte Awaiting requested review from katbyte

@WodansSon WodansSon Awaiting requested review from WodansSon

Assignees
No one assigned
Labels
enhancement service/devspace size/M
Projects
None yet
Milestone
v1.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@metacpp @tombuildsstuff