Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eventhub: updating the namespace SDK to use API Version 2021-01-01-preview #12290

Merged
merged 2 commits into from
Jun 21, 2021
Merged

eventhub: updating the namespace SDK to use API Version 2021-01-01-preview #12290

merged 2 commits into from
Jun 21, 2021

Conversation

tombuildsstuff
Copy link
Contributor

This PR updates the namespace SDK to use API Version 2021-01-01-preview - required to support encryption

@tombuildsstuff tombuildsstuff added this to the v2.65.0 milestone Jun 21, 2021
@tombuildsstuff tombuildsstuff force-pushed the f/eventhub-sdk-upgrade branch 2 times, most recently from d3683b6 to 42f76ed Compare June 21, 2021 08:46
@tombuildsstuff tombuildsstuff force-pushed the f/eventhub-sdk-upgrade branch from 42f76ed to 2190a42 Compare June 21, 2021 09:19
@tombuildsstuff tombuildsstuff mentioned this pull request Jun 21, 2021
Merged
@tombuildsstuff
Copy link
Contributor Author

Ignoring a couple of quota related/flaky tests the tests look good:

Screenshot 2021-06-21 at 16 26 45

@tombuildsstuff tombuildsstuff requested a review from a team June 21, 2021 14:27
katbyte
katbyte approved these changes Jun 21, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit d81429c into master Jun 21, 2021
@tombuildsstuff tombuildsstuff deleted the f/eventhub-sdk-upgrade branch June 21, 2021 15:15
tombuildsstuff added a commit that referenced this pull request Jun 21, 2021
@tombuildsstuff
updating to include #12290
c2d7dcd
@github-actions
Copy link

This functionality has been released in v2.65.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@mhennecke mhennecke mentioned this pull request Jun 26, 2021
Closed
@ramondeklein ramondeklein mentioned this pull request Jul 5, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
service/event-hubs EventHubs size/L
Projects
None yet
Milestone
v2.65.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @katbyte