Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating the Eventhubs SDK for 2021-01-01-preview #97

Merged
merged 8 commits into from
Jun 28, 2021

Conversation

tombuildsstuff
Copy link
Contributor

Which is the basis of hashicorp/terraform-provider-azurerm#12290

Finally, this PR adds a (currently failing) test for #96 and fixes a couple of other minor bugs

…an the service name

This is used to uniquely identify the Resources present within a Service Version, so needs
to be unique
… them

This ensures a consistent order which removes spurious changes in the output
… outputting them

This ensures a consistent order which removes spurious changes
…eferenced model

This handles the User Assigned Identity bug seen in EventHub Namespaces 2021-01-01-preview
@tombuildsstuff tombuildsstuff requested a review from a team June 22, 2021 11:54
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 1fa810b into main Jun 28, 2021
@tombuildsstuff tombuildsstuff deleted the f/eventhub-2021-01-01-preview branch June 28, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants