Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_kubernetes_cluster: support for ingress_application_gateway addon #11376

Merged
merged 18 commits into from
Apr 27, 2021
Merged

azurerm_kubernetes_cluster: support for ingress_application_gateway addon #11376

merged 18 commits into from
Apr 27, 2021

Conversation

markrzasa
Copy link
Contributor

@markrzasa markrzasa commented Apr 19, 2021 •
edited by magodo
Loading

Hi Everyone,

I didn't realize the following pull request existed before starting this one:

#9419

However, it looks like that pull request is no longer in development. I tried to address the comments in that pull request in this pull request.

Please let me know what you think.

Thanks,
Mark

Fixes: #7384

magodo
magodo requested changes Apr 20, 2021
View reviewed changes
Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markrzasa Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍

azurerm/internal/services/containers/kubernetes_addons.go Outdated Show resolved Hide resolved
azurerm/internal/services/containers/kubernetes_addons.go Outdated Show resolved Hide resolved
azurerm/internal/services/containers/kubernetes_cluster_addons_resource_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/containers/kubernetes_cluster_addons_resource_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/containers/kubernetes_cluster_addons_resource_test.go Outdated Show resolved Hide resolved
website/docs/r/kubernetes_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/kubernetes_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/kubernetes_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/kubernetes_cluster.html.markdown Outdated Show resolved Hide resolved
azurerm/internal/services/containers/kubernetes_addons.go Show resolved Hide resolved
@magodo magodo mentioned this pull request Apr 20, 2021
Closed
@markrzasa
Copy link
Contributor Author

@magodo thanks for taking the time to review these changes. I'll try to get these comments addressed in the next couple of days.

@markrzasa
Copy link
Contributor Author

All comments should be addressed. Please let me know if anything else needs work. Thanks.

magodo
magodo requested changes Apr 24, 2021
View reviewed changes
Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markrzasa
I have left some additional mostly minor comments that once addressed this should be good to merge 👍

azurerm/internal/services/containers/kubernetes_cluster_addons_resource_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/containers/kubernetes_cluster_addons_resource_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/containers/kubernetes_cluster_addons_resource_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/containers/kubernetes_cluster_addons_resource_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/containers/kubernetes_cluster_addons_resource_test.go Show resolved Hide resolved
azurerm/internal/services/containers/kubernetes_cluster_addons_resource_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/containers/kubernetes_addons.go Outdated Show resolved Hide resolved
website/docs/r/kubernetes_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/d/kubernetes_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/d/kubernetes_cluster.html.markdown Outdated Show resolved Hide resolved
@markrzasa
Copy link
Contributor Author

@magodo
Thanks again for the review. I think I've covered all of you comments.

@magodo
Copy link
Collaborator

magodo commented Apr 25, 2021

Thank you @markrzasa! This LGTM 👍

@magodo magodo added this to the v2.57.0 milestone Apr 25, 2021
@markrzasa
Copy link
Contributor Author

@magodo
Would you mind rerunning the workflows? I believe they failed because my fork was out of date.

Thanks again for all of the help. It's much appreciated.

katbyte
katbyte approved these changes Apr 27, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @markrzasa - LGTM 👍

@katbyte katbyte merged commit c16d32f into hashicorp:master Apr 27, 2021
@katbyte katbyte changed the title AKS: support for ingress_application_gateway addon azurerm_kubernetes_cluster: support for ingress_application_gateway addon Apr 27, 2021
katbyte added a commit that referenced this pull request Apr 27, 2021
@katbyte
CHANGELOG.md for #11376
5982ace
alvintang pushed a commit to alvintang/terraform-provider-azurerm that referenced this pull request Apr 29, 2021
@markrzasa @alvintang
AKS: support for ingress_application_gateway addon (hashicorp#11376)
6ef28d8 
Hi Everyone,

I didn't realize the following pull request existed before starting this one:

hashicorp#9419

However, it looks like that pull request is no longer in development. I tried to address the comments in that pull request in this pull request.

Please let me know what you think.

Thanks,
Mark
alvintang pushed a commit to alvintang/terraform-provider-azurerm that referenced this pull request Apr 29, 2021
@katbyte @alvintang
CHANGELOG.md for hashicorp#11376
dd6000b
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@Flektoma Flektoma mentioned this pull request May 3, 2021
Closed
@aristosvo aristosvo mentioned this pull request May 8, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@magodo magodo magodo requested changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/kubernetes-cluster size/XL
Projects
None yet
Milestone
v2.57.0
Development

Successfully merging this pull request may close these issues.

Support for ingress-appgw add-on in azurerm_kubernetes_cluster
3 participants
@markrzasa @magodo @katbyte