Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User & Group improvements #476

Merged
merged 15 commits into from
Jul 21, 2021
Merged

User & Group improvements #476

merged 15 commits into from
Jul 21, 2021

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Jul 6, 2021

  • Upgrade Hamilton to v0.21.0

Note: This PR currently targets f/application-improvements since there are dependent changes in there - once that PR is merged this can go to main (as such the diff is showing a few changes that are already merged)

Groups

  • Support the assignable_to_role property
  • Support the behaviors property
  • Support the mail_nickname property
  • Support the provisioning_options property
  • Support the theme property
  • Support the visibility property
  • Export the mail attribute
  • Export the onpremises_domain_name attribute
  • Export the onpremises_netbios_name attribute
  • Export the onpremises_sam_account_name attribute
  • Export the onpremises_security_identifier attribute
  • Export the onpremises_sync_enabled attribute
  • Export the preferred_language attribute
  • Export the proxy_addresses attribute

Users

  • Support the age_group property
  • Support the business_phones property
  • Support the consent_provided_for_minor property
  • Support the employee_id property
  • Support the fax_number property
  • Support the mail property
  • Support the other_mails property
  • Support the preferred_language property
  • Support the show_in_address_list property
  • Export the creation_type attribute
  • Export the external_user_state attribute
  • Export the im_addresses attribute
  • Export the onpremises_distinguished_name attribute
  • Export the onpremises_domain_name attribute
  • Export the onpremises_security_identifier attribute
  • Export the onpremises_sync_enabled attribute
  • Export the proxy_addresses attribute

Closes: #240
Closes: #312
Closes: #452

@manicminer manicminer changed the base branch from main to f/application-improvements July 6, 2021 14:02
@manicminer manicminer requested a review from a team July 6, 2021 14:09
@manicminer manicminer added this to the v2.0.0 milestone Jul 6, 2021
@manicminer manicminer force-pushed the f/user-group-improvements branch 2 times, most recently from 4379faa to f51157c Compare July 6, 2021 15:48
@manicminer
Copy link
Contributor Author

Test results

Screenshot 2021-07-06 at 17 28 00

Screenshot 2021-07-06 at 17 19 14

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manicminer! LGTM 🚀🍔

@manicminer manicminer force-pushed the f/user-group-improvements branch from aa6b757 to 21d8c20 Compare July 21, 2021 22:01
Base automatically changed from f/application-improvements to main July 21, 2021 22:15
@manicminer manicminer merged commit cbd28d1 into main Jul 21, 2021
@manicminer manicminer deleted the f/user-group-improvements branch July 21, 2021 22:25
manicminer added a commit that referenced this pull request Jul 21, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants