Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_group description change should not create a new resource #240

Closed
trajano opened this issue Apr 11, 2020 · 4 comments · Fixed by #476
Closed

azuread_group description change should not create a new resource #240

trajano opened this issue Apr 11, 2020 · 4 comments · Fixed by #476

Comments

@trajano
Copy link

trajano commented Apr 11, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritise this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritise the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureAD Provider) Version

Terraform v0.12.24
+ provider.azuread v0.8.0

Affected Resource(s)

  • azuread_group

Terraform Configuration Files

resource "azuread_group" "SonarQubeAdministrators" {
  name = "SonarQube Administrators"
  description = "SonarQube Administrators"
  owners = [
      data.azuread_user.it.id,
      data.azuread_user.vp_tech.id,
  ]
}

Debug Output

Panic Output

Expected Behavior

Changing the description only should not create a new resource as the Portal allows changing the text without changing the object ID.

Actual Behavior

Changing the description only creates a new resource.

Steps to Reproduce

  1. terraform apply

Important Factoids

References

  • #0000
@katbyte
Copy link
Collaborator

katbyte commented May 15, 2020

@trajano,

currently the SDK doesn't have an update methold, just create. Until the SDK supports updating group descriptions (maybe the new graph one does) we won't be able to fix this 😞

@manicminer
Copy link
Contributor

I've raised an upstream feature request for this, as the current API does support PATCH requests for groups.

Upstream isue: Azure/azure-sdk-for-go#9911
API operation: https://docs.microsoft.com/en-gb/previous-versions/azure/ad/graph/api/groups-operations#update-a-group--

@manicminer
Copy link
Contributor

Related: #176

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants