Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource: application_pre_authorized #472

Merged
merged 2 commits into from
Jul 2, 2021
Merged

New resource: application_pre_authorized #472

merged 2 commits into from
Jul 2, 2021

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Jun 30, 2021 •
edited
Loading

This is implemented as a standalone resource as it references oauth2 permission scope IDs on the same application, that must exist, and be enabled, prior to setting the preAuthorizedApplications property.

Note: PR currently targets v2 branch, but will change to main once #461 is merged

Closes: #263
Closes: #451

@manicminer manicminer added this to the v2.0.0 milestone Jun 30, 2021
@manicminer manicminer force-pushed the r/pre-authorized-application branch from 99e9a0e to b17e985 Compare June 30, 2021 11:56
@manicminer manicminer force-pushed the r/pre-authorized-application branch from b17e985 to 8c94fe9 Compare June 30, 2021 11:58
@manicminer manicminer changed the base branch from main to v2 June 30, 2021 11:58
katbyte
katbyte approved these changes Jul 1, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from one comment LGTM 🍰

docs/resources/pre_authorized_application.md Outdated Show resolved Hide resolved
Base automatically changed from v2 to main July 2, 2021 08:40
@manicminer manicminer changed the title New resource: pre_authorized_application New resource: application_pre_authorized Jul 2, 2021
@manicminer manicminer merged commit 650afc5 into main Jul 2, 2021
@manicminer manicminer deleted the r/pre-authorized-application branch July 2, 2021 15:08
@sdaggulakr sdaggulakr mentioned this pull request Jul 2, 2021
Closed
manicminer added a commit that referenced this pull request Jul 2, 2021
@manicminer
Changelog for #472
3a1b795
manicminer added a commit that referenced this pull request Jul 6, 2021
@manicminer
Changelog for #472
14c7130
@github-actions
Copy link

github-actions bot commented Aug 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
api/microsoft-graph feature/applications new-resource
Projects
None yet
Milestone
v2.0.0
2 participants
@manicminer @katbyte