Initial v2.0 changes #461
Merged
Initial v2.0 changes #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
force-pushed
the
v2
branch
3 times, most recently
from
8a5bb41 to
86e8a3d
Compare
katbyte
requested changes
Jun 17, 2021
internal/services/applications/application_app_role_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/applications/application_oauth2_permission_scope_resource_test.go
Outdated
Show resolved
Hide resolved
…t are used by more than one service package
…ors (i.e. not just diagnostics) for use in CustomizeDiff functions
- Remove deprecated fields - Remove deprecated resources - `azuread_application_app_role` - `azuread_application_oauth2_permission_scope` - `azuread_application_oauth2_permissions` - Remove Computed on all fields where it makes sense - Enables zeroing/removing property and block values - More reliably detect changes azuread_application - Change `group_membership_claims` to a set - Support `saml2_token` for `optional_claims` - Support all values for `sign_in_audience` - Support `id_token_issuance_enabled` for `implicit_grant` azuread_application_password - key_id and value are now Computed due to API restrictions
data.azuread_domains - Support additional properties: admin_managed, only_root and supports_services - Remove `is_` prefix on exported fields - Additional exported fields: admin_managed, root and supported_services
azuread_group - Support updating groups - Add support for creating mail enabled groups (365 only due to API limitation) - Add support for creating Microsoft 365 groups - Breaking: now require at least one of security_enabled or mail_enabled to be specified
- Remove deprecated fields azuread_service_principal_password - key_id and value are now Computed due to API restrictions - start_date and end_date are now Computed due to an API or documentation bug
- Remove deprecated fields - Remove Computed on all fields where it makes sense - Enables zeroing/removing property and block values - More reliably detect changes - Support importing users without breaking their password by making `password` optional+computed
- Use less secrety fake secrets - Comment the app/role/scope IDs used in examples - Helpful shell quoting in guide command examples
This was referenced Jun 30, 2021
katbyte
approved these changes
Jul 1, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comprises the initial set of changes to move towards v2.0, primarily:
aadgraphhelpers packagemsgraphhelpers package to only include functions that are used by more than one packagemsgraph.StringNullWhenEmptytypeApplications
azuread_application_oauth2_permissionsazuread_application
group_membership_claimsto a setsaml2_tokenforoptional_claimssign_in_audienceid_token_issuance_enabledforimplicit_grantazuread_application_password
Domains
data.azuread_domains
admin_managed,only_rootandsupports_servicesis_prefix on exported fieldsadmin_managed,rootandsupported_servicesGroups
azuread_group
security_enabledormail_enabledto be specifiedService Principals
azuread_service_principal_password
key_idandvalueare now Computed due to API restrictionsstart_dateandend_dateare now Computed due to an API or documentation bugUsers
passwordoptional+computedChecklist
Closes: #163
Closes: #176
Closes: #208
Closes: #236
Closes: #282
Closes: #305
Closes: #308
Closes: #311
Closes: #328
Closes: #334
Closes: #337
Closes: #340
Closes: #362
Closes: #371
Closes: #375
Closes: #377
Closes: #408
Closes: #420
Closes: #424
Closes: #449
Closes: #467
Closes: #470